Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication visual nits #8325

Closed
1 of 7 tasks
lampholder opened this issue Jan 30, 2019 · 2 comments
Closed
1 of 7 tasks

Authentication visual nits #8325

lampholder opened this issue Jan 30, 2019 · 2 comments

Comments

@lampholder
Copy link
Member

lampholder commented Jan 30, 2019

Stuff worth fixing:

More trivial stuff:

  • https://matrix.org is an odd placeholder for modular since it's almost the one value we never expect anyone to put into this field
  • On both the modular and advanced flows, I didn't see the edit option to change the homeserver details because I was looking for a 'back' button (as a counterpart to the next button that brought me here)
  • auth fields nudged out of place by password manager UX (not suggesting we fix this)
    image
  • I get a scrollbar on the slightly-taller matrix.org registration page which I don't get on the other pages, so the centralised main box nudges left and right as I switch between matrix/modular/advanced
@jryans jryans changed the title Login/Registration issues Authentication visual nits Jan 30, 2019
@lampholder
Copy link
Member Author

Just making a quick note here of the things I tested which worked:

  • registering on a HS which does not support msisdns
    • the phone number field did not appear
  • registering on a HS which does not support registration
    • an error message appeared before I tried to register (though the fields were still enabled, which could be better)
  • registering on a HS which requires email address
    • the "(optional)" text was removed from the email field placeholder

@lampholder
Copy link
Member Author

I think all of these issues have since been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants