Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Edit" link in registration to "Change" #8853

Closed
jryans opened this issue Feb 21, 2019 · 1 comment
Closed

Change "Edit" link in registration to "Change" #8853

jryans opened this issue Feb 21, 2019 · 1 comment
Assignees
@jryans
Labels
A-Authentication A-Registration P3 T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 21, 2019

Since we now have various flows where you may not have entered the HS yourself, "Change" seems like a better, more generic very to use than "Edit".
@bwindels bwindels mentioned this issue Feb 21, 2019
Closed
41 tasks
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 21, 2019
@jryans
Relabel custom HS link on registration from 'Edit' to 'Change'
8b66b6b 
Fixes element-hq/element-web#8853
@jryans
Copy link
Collaborator Author

jryans commented Feb 21, 2019

Fixed in matrix-org/matrix-react-sdk@8b66b6b.

@jryans jryans self-assigned this Feb 21, 2019
@jryans jryans closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P3 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @lampholder