Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styling for copy to clipboard button #4204

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Added styling for copy to clipboard button #4204

merged 2 commits into from
Jun 8, 2017

Conversation

ollieh
Copy link
Contributor

@ollieh ollieh commented Jun 5, 2017

Currently using the edit button's image as a placeholder, it needs its own icon.

Paired with matrix-org/matrix-react-sdk#1040

See issue #1974

Should I have a go at creating one myself, or is there someone responsible for creating the icons?

@ollieh ollieh changed the base branch from master to develop June 5, 2017 23:41
ollieh added 2 commits June 6, 2017 12:37
… button's image as a placeholder

Signed-off-by: Oliver Hunt <oliver@hunt.bz>
…bably replace these!

Signed-off-by: Oliver Hunt <oliver@hunt.bz>
@ollieh
Copy link
Contributor Author

ollieh commented Jun 6, 2017

What the new icons look like:
newicons
I noticed the existing light theme button used specific colours, but the dark theme uses white and black with transparencies. I copied the settings from these for consistency, but I think it looks odd in the dark theme, there isn't enough contrast between the light colour and the dark colour.
Existing icons for reference:
existingicons

@t3chguy
Copy link
Member

t3chguy commented Jun 7, 2017

/me schedules a build
...
https://riot.ovh/builds/code-copy-clipboard

@ollieh
Copy link
Contributor Author

ollieh commented Jun 7, 2017

Nice, it appears to be working. I do wonder if it would be worth code blocks having a different background colour than the message when you hover over the message, or a border. Had a little play:
backgroundcolorcode
bordercode

@ara4n
Copy link
Member

ara4n commented Jun 8, 2017

ooh, this is great - thanks! (although i haven't looked at the code yet) the 1px border is a great idea too - can you push the CSS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants