Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up acknowledgements configuration for sinks after they all support it #13664

Closed
Tracked by #12145
bruceg opened this issue Jul 21, 2022 · 0 comments · Fixed by #13760
Closed
Tracked by #12145

Clean up acknowledgements configuration for sinks after they all support it #13664

bruceg opened this issue Jul 21, 2022 · 0 comments · Fixed by #13760
Assignees
@bruceg
Labels
domain: config Anything related to configuring Vector domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: delivery Anything related to delivering events within Vector such as end-to-end acknowledgements type: tech debt A code change that does not add user value.

Comments

@bruceg
Copy link
Member

bruceg commented Jul 21, 2022

Once all the sinks have support for end-to-end acknowledgements (#9857), there will be some opportunities to move the boilerplate bits of that handling up out of the individual sinks and into the global configuration layer. This will ease the creation of new sinks and reduce the possibilities for errors in handling this configuration.
@bruceg bruceg added type: tech debt A code change that does not add user value. domain: config Anything related to configuring Vector domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: delivery Anything related to delivering events within Vector such as end-to-end acknowledgements labels Jul 21, 2022
This was referenced Jul 29, 2022
Closed
Merged
@bruceg bruceg self-assigned this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruceg bruceg

Labels
domain: config Anything related to configuring Vector domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: delivery Anything related to delivering events within Vector such as end-to-end acknowledgements type: tech debt A code change that does not add user value.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sinks): Make acknowledgement configuration non-optional vectordotdev/vector
1 participant
@bruceg