Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more compression algorithms to prometheus_remote_write #17199

Closed
zamazan4ik opened this issue Apr 23, 2023 · 3 comments · Fixed by #17334
Closed

Add more compression algorithms to prometheus_remote_write #17199

zamazan4ik opened this issue Apr 23, 2023 · 3 comments · Fixed by #17334
Labels
domain: compression Anything related to compressing data within Vector sink: prometheus_remote_write Anything `prometheus_remote_write` sink related source: prometheus_remote_write Anything `prometheus_remote_write` source related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@zamazan4ik
Copy link
Contributor

zamazan4ik commented Apr 23, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

According to the issue, VictoriaMetrics team is interested in gzip/zstd compression support.

Vector right now supports only Snappy: https://github.com/vectordotdev/vector/blob/master/src/sinks/prometheus/remote_write.rs#L357

Attempted Solutions

No response

Proposal

Add GZip and ZSTD support to prometheus_remote_write sink.

References

No response

Version

No response

@zamazan4ik zamazan4ik added the type: feature A value-adding code addition that introduce new functionality. label Apr 23, 2023
@bruceg bruceg added type: enhancement A value-adding code change that enhances its existing functionality. domain: compression Anything related to compressing data within Vector source: prometheus_remote_write Anything `prometheus_remote_write` source related sink: prometheus_remote_write Anything `prometheus_remote_write` sink related and removed type: feature A value-adding code addition that introduce new functionality. labels Apr 24, 2023
@zamazan4ik
Copy link
Contributor Author

Found another point for improvement. We need to document:

  • Supported compression algorithms by prometheus_remote_write source. Right now it supports Deflate, Gzip, Snappy, Zstd
  • After the addition Gzip and Zstd compression algorithms to prometheus_remote_write sink - do not forget to document it.

By the way, what is the better way to add custom compression algorithms to prometheus_remote_write sink? Usual compression field in the config of the sink?

And once again I would like to highlight the issue - we still do not have a generic way to specify the compression level for the compression algorithms. It could be useful for tuning compression/CPU consumption ratio.

@jszwedko
Copy link
Member

jszwedko commented May 3, 2023

By the way, what is the better way to add custom compression algorithms to prometheus_remote_write sink? Usual compression field in the config of the sink?

Yeah, I think we'd just follow the existing patterns to add these new algorithms.

@valyala
Copy link

valyala commented May 13, 2023

It would be great to have the ability to use zstd compression for Prometheus remote_write protocol in order to be compatible with VictoriaMetrics components - see https://victoriametrics.com/blog/victoriametrics-remote-write/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: compression Anything related to compressing data within Vector sink: prometheus_remote_write Anything `prometheus_remote_write` sink related source: prometheus_remote_write Anything `prometheus_remote_write` source related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants