Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch NATS sink events #18272

Open
StephenWakely opened this issue Aug 16, 2023 · 1 comment
Open

Batch NATS sink events #18272

StephenWakely opened this issue Aug 16, 2023 · 1 comment
Labels
sink: nats Anything `nats` sink related type: feature A value-adding code addition that introduce new functionality.

Comments

@StephenWakely
Copy link
Contributor

StephenWakely commented Aug 16, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

A recent change to the NATS sink meant we need to flush the connection for each event so we can guarantee that the event was delivered before reporting success.

This could potentially affect the throughput. It could well be worth considering introducing batching to the sink so that we flush only after each batch.0

Version

V0.32.0

@StephenWakely StephenWakely added the type: feature A value-adding code addition that introduce new functionality. label Aug 16, 2023
@jszwedko jszwedko added the sink: nats Anything `nats` sink related label Aug 16, 2023
@jszwedko
Copy link
Member

jszwedko commented Sep 7, 2023

Note: this sort of batching (of NATS messages) would be different from the existing batch concept (batching within a NATS message) in Vector sinks so we wouldn't want to expose it to users in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: nats Anything `nats` sink related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants