Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_s3 source should log what it's ingesting #21128

Open
fdamstra opened this issue Aug 21, 2024 · 0 comments · May be fixed by #22083
Open

aws_s3 source should log what it's ingesting #21128

fdamstra opened this issue Aug 21, 2024 · 0 comments · May be fixed by #22083
Labels
source: aws_s3 Anything `aws_s3` source related type: feature A value-adding code addition that introduce new functionality.

Comments

@fdamstra
Copy link
Contributor

fdamstra commented Aug 21, 2024

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

When troubleshooting an aws_s3 source for missing data, we should have a log of which s3 buckets + keys were retrieved. Unlike the aws_sqs source, where such logging would be excessive, for aws_s3 sources there can be many, many events in a single file in s3.

Attempted Solutions

We tried using the metadata along with suppression to log in a remap, similar to:

  log("Processing (or continuing to process) S3 URL: s3://" + bucket + "/" + key, level: "warn", rate_limit_secs: 300)

But rate-limiting appears to apply to the caller location and not the particular message being logged. So this mesage will only appear once every 5 minutes no matter how many different buckets + keys were read.

Proposal

Add logging to record which s3 urls are being ingested.

References

No response

Version

vector 0.38.0 (x86_64-unknown-linux-gnu ea0ec6f 2024-05-07 14:34:39.794027186)

@fdamstra fdamstra added the type: feature A value-adding code addition that introduce new functionality. label Aug 21, 2024
@jszwedko jszwedko added the source: aws_s3 Anything `aws_s3` source related label Aug 22, 2024
@fdamstra fdamstra linked a pull request Dec 26, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: aws_s3 Anything `aws_s3` source related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants