Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting higher concurrency for loki sink #6932

Closed
jszwedko opened this issue Mar 30, 2021 · 0 comments · Fixed by #8615
Closed

Allow setting higher concurrency for loki sink #6932

jszwedko opened this issue Mar 30, 2021 · 0 comments · Fixed by #8615
Assignees
Labels
sink: loki Anything `loki` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@jszwedko
Copy link
Member

Requested by user: #6041 (comment)

@jszwedko As part of #5973, the request.concurrency configuration was disabled as a workaround to eliminate out-of-order issues. Although this eliminates out-of-order issues in Loki, it also reduces overall throughput. You made a review comment stating:

Instead of hard-coding to 1, maybe we could still let users set it if they really know what they are doing, but output a warning?

I would preference this to be a warning instead of a hard-coded value. Perhaps this should be included as part of the documentation rather than limiting the performance of vector?

In addition, there is progress in Loki to provide some leniency around out-of-order log submissions.

Is there a chance we could get request.concurrency re-enabled with a warning and/or documentation for users who may not understand the implications of increasing this value?

We should still do #6041 too, but this would be an easier fix to unblock users that are able to manage the higher concurrency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: loki Anything `loki` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
2 participants