Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the prometheus_exporter sink into the new style #9447

Closed
Tracked by #9261
binarylogic opened this issue Oct 4, 2021 · 1 comment
Closed
Tracked by #9261

Rewrite the prometheus_exporter sink into the new style #9447

binarylogic opened this issue Oct 4, 2021 · 1 comment
Assignees
@fuchsnj
Labels
domain: performance Anything related to Vector's performance domain: sinks Anything related to the Vector's sinks sink: prometheus_exporter Anything `prometheus_exporter` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

No description provided.

@binarylogic binarylogic mentioned this issue Oct 4, 2021
Open
40 tasks
@binarylogic binarylogic added domain: performance Anything related to Vector's performance domain: sinks Anything related to the Vector's sinks sink: prometheus_exporter Anything `prometheus_exporter` sink related type: enhancement A value-adding code change that enhances its existing functionality. labels Oct 4, 2021
@fuchsnj fuchsnj self-assigned this Nov 30, 2021
@fuchsnj
Copy link
Member

fuchsnj commented Dec 1, 2021

The sink is already in the new style. It does not have some of the "required" metrics, such as EventsSent and BytesSent, but we decided those don't make a lot of sense for this "pull-based" sink. So there is nothing to do here.

@fuchsnj fuchsnj closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuchsnj fuchsnj

Labels
domain: performance Anything related to Vector's performance domain: sinks Anything related to the Vector's sinks sink: prometheus_exporter Anything `prometheus_exporter` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binarylogic @fuchsnj