Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently 'forget contact' permission in contact GDPR tab requires 'administer GDPR' permission #114

Closed
mhawksey opened this issue May 23, 2018 · 2 comments
Milestone

Comments

@mhawksey
Copy link
Contributor

Currently to use the 'forget contact' button the user also needs 'administer GDPR' permission. It would be good if this the admin permission was not required to allow delegation to team members.

Relevant lines:
https://github.com/veda-consulting/uk.co.vedaconsulting.gdpr/blob/fe3e51145abc8822dd1e447e5b16122e9ecaac17/templates/CRM/Gdpr/Page/Tab.tpl#L2-L10

@tbuytaer
Copy link
Contributor

Instead of removing the permission check it would seem better to replace it with a separate permission to "forget contact".
Otherwise anyone with some kind of access to CiviCRM can forget contacts.

See PR #19

@mhawksey
Copy link
Contributor Author

There is still a 'forget contact' permission check so delegation is permitted. The issue is in the current code within the 'forget contact' check the button is only rendered of the person also has administer permissions. This PR keeps the 'forget contact' but removes the 'administer GDPR' requirement.

@veda-consulting veda-consulting added this to the Version 2.6 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants