Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: svelte-vega now exports VisualizationSpec #30

Merged
merged 2 commits into from
May 7, 2021
Merged

Conversation

Sparkier
Copy link
Collaborator

@Sparkier Sparkier commented May 4, 2021

Now exporting VisualizationSpec directly from svelte-vega, so no need to import vega-embed for that
anymore.

re #29

@Sparkier Sparkier requested a review from domoritz May 4, 2021 15:22
@Sparkier Sparkier self-assigned this May 4, 2021
@domoritz
Copy link
Member

domoritz commented May 4, 2021

Great. Do I read this correctly that there is no new feature?

@Sparkier
Copy link
Collaborator Author

Sparkier commented May 5, 2021

Great. Do I read this correctly that there is no new feature?

Yes, this is only about exposing the specs to be imported directly from our package.

Alex Bäuerle added 2 commits May 6, 2021 18:57
Now exporting VisualizationSpec directly from svelte-vega, so no need to import vega-embed for that
anymore.

re #29
Now also individually exports Vega and VegaLite specs.

re #29
@Sparkier Sparkier force-pushed the alex/specexport branch from 6459745 to a1d8be9 Compare May 6, 2021 16:57
@domoritz domoritz changed the title chore: svelte-vega now exports VisualizationSpec docs: svelte-vega now exports VisualizationSpec May 6, 2021
@Sparkier Sparkier changed the title docs: svelte-vega now exports VisualizationSpec feat: svelte-vega now exports VisualizationSpec May 7, 2021
@Sparkier Sparkier merged commit 306d5f3 into main May 7, 2021
@Sparkier Sparkier deleted the alex/specexport branch May 7, 2021 07:29
@vega-org-bot
Copy link
Collaborator

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose VisualizationSpec, VegaLiteSpec, and VegaSpec types from component
3 participants