Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ledger entry CSV export query to make clearer and add the maker rebate #8353

Closed
gordsport opened this issue May 23, 2023 · 1 comment · Fixed by #8432
Closed

Update ledger entry CSV export query to make clearer and add the maker rebate #8353

gordsport opened this issue May 23, 2023 · 1 comment · Fixed by #8432
Assignees
Labels
api datanode enhancement New feature or request

Comments

@gordsport
Copy link
Contributor

gordsport commented May 23, 2023

Issue

During initial testing of the first mainnet market it has been identified that we need to make some updates to the ledger entry CSV export:

Required for 0.71.x patch:

  • remove the \x from the IDs in the CSV
  • add the following missing fields to the CSV:
    • MTM gains and losses
    • Any original deposits of assets
    • maker rebate (thats not shown)
  • update the account types as these are enums and ideally should be user readable as account types

Other points to consider:

  • NICE TO HAVE (possible new ticket to be raised - if not simple/low risk for the patch): Its not particularly easy to be able to work out the in/out accounting for auditing purposes. Can any enhancements be made to help users do their accounting e.g., positive and negative numbers so summing is easier.
    • can we have a column e.g., net that shows positive/negative values or 0 if the transfer is between accounts on the same public key
@pscott31
Copy link
Contributor

the most important thing here is to show ledger entries in/out of a parties' accounts, currently we only show entries out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api datanode enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants