Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nodes are not respected in the config templating #368

Open
3 tasks
daniel1302 opened this issue Jan 3, 2023 · 0 comments
Open
3 tasks

New nodes are not respected in the config templating #368

daniel1302 opened this issue Jan 3, 2023 · 0 comments

Comments

@daniel1302
Copy link
Contributor

daniel1302 commented Jan 3, 2023

Let's say We have the following line of the config in the data-node config:

BootstrapPeers = [{{- range $i, $peer := .IPSFPeers -}}
      {{- if ne $i 0 }},{{end -}}
      "/ip4/127.0.0.1/tcp/4{{ printf "%02d" $peer.Index }}5/ipfs/{{ $peer.ID }}"
    {{- end -}}]

Then when we have one data node in the config.hcl We get the following output:

BootstrapPeers = ["/ip4/127.0.0.1/tcp/4025/ipfs/12D3KooWDhDcgBCEYxqAsQGYkNWQboeVacCMEuhMtRJbYsiKPFLH"]

Then, We want to add a node with the following command:

vegacapsule nodes add --base-on "$DATA_NODE_BASE" --start=false --out-path ./new-data-node.json;

And We are getting the same config as previously, but I believe we should get two bootstrap nodes:

BootstrapPeers = ["/ip4/127.0.0.1/tcp/4025/ipfs/.....", "/ip4/127.0.0.1/tcp/4035/ipfs/....."]

I am currently doing this fix manually as the workaround.

TODO:

  1. Rethink if this solution needs to be implemented
  2. Implement the solution
  3. Make sure no pipeline is broken.
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Jan 6, 2023
@gordsport gordsport removed this from the ☄️ Cosmic Elevator milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants