Replies: 2 comments 1 reply
-
This branch is definitely still in development, sorry for the confusion. I do appreciate the feedback though! I've added notes with your feedback to the to-do list in the PR. Feel free to reach out on Discord - I'd love to collaborate. |
Beta Was this translation helpful? Give feedback.
-
I couldn't find any documentation about this - are you able to share a link? I think given the complexity of the configuration, I'd almost rather it be a JSON file or something.
The goal here is to make the build process more repeatable - the Makefile runs the build in a Docker container configured in a way that we know will work, ensuring we have all of the correct dependencies, node versions, etc. Most people are probably running a newer version of Node on their machine for local tasks, so this prevents forcing people to install another Node and potentially messing up their other development environments just to update Sharp. The Makefile also gives us the opportunity to configure additional parameters for building Sharp from scratch down the road.
It's a million times better - especially in a project like this where there's so much data flow. Trust me. I found 5 or 6 bugs in the old code just from the type-checking.
Good catch - we should fix that. |
Beta Was this translation helpful? Give feedback.
-
I have pulled your latest "modernize" branch, which you're trying to upgrade to the latest serverless-sharp, and a number of other tweaks.
I tried deploying, but stuck with some error messages in serverless.yml.
May I ask if this is still a WIP branch?
There are also a number of things I noticed:
serverless deprecates the usage of settings.yml, and promotes usage of env files. Would you considering going for the latter option? I can assist maybe if you're ok?
I see there is some Makefile and stuff. But the sharp layer for Lambda doesn't really require any building I think.
All I did on my end is:
npm install --platform=linux --arch=x64 sharp
Or did I miss anything here?
Switched over to use TS. Actually I have no experience on this part. Is it really better?
TLSv1 <-- still uses this protocol. AWS seems to already recommend 'TLSv1.2_2021'
=====
Btw, @Mosnar any communication tools you use? I think we can exchange contacts, it can make our communication easier, and also to make a new overseas friend ;-) If you're interested of course.
Beta Was this translation helpful? Give feedback.
All reactions