From 115f927b9bd16fe01ab8ee410ead77e8eebd324d Mon Sep 17 00:00:00 2001 From: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Date: Tue, 6 Jun 2023 11:44:39 -0700 Subject: [PATCH] ci(workflow): loosen condtions for uploading turbopack bytesize (#50820) ### What? It turned out the recommendation https://github.com/vercel/next.js/pull/50600/files#r1212902688 is overly strict, even if it's valid build work we skips to upload data and only triggers for the release. This is an example workflow https://github.com/vercel/next.js/actions/runs/5182537384/jobs/9339461369 that build ran but upload skipped. We are fine with same bytesize numbers with cache hit actually, and can filter it out in worst cases - so loosening conditions for now. --- .github/workflows/build_and_deploy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 8216e812908ad..8ca3dd0bda481 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -173,6 +173,7 @@ jobs: TURBO_TEAM: 'vercel' TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }} TURBO_REMOTE_ONLY: 'true' + DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }} steps: # https://github.com/actions/virtual-environments/issues/1187 - name: tune linux network @@ -245,10 +246,10 @@ jobs: # Trying to upload metrics for the Turbopack to datadog's CI pipeline execution - name: 'Upload turbopack build metrics' shell: bash - if: ${{ needs.build.outputs.isRelease == 'true' }} continue-on-error: true run: | npm install -g @datadog/datadog-ci + shopt -s nullglob for filename in packages/next-swc/native/next-swc.*.node; do # Strip out filename to extract target triple export FILENAME=$(basename ${filename})