From 26a4eb827c384288a4185bdbe14233c025c96dbd Mon Sep 17 00:00:00 2001
From: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Date: Fri, 29 Mar 2019 11:20:12 -0500
Subject: [PATCH] Add dropping of custom scripts in AMP mode (#6830)

Drops user `<script>` tags and shows a warning in AMP mode. Right now they are only dropped in production mode and left in dev mode so the validator shows its warning since it looks like conflicting props log messages are being cleared causing them to not show.

Closes: #6688
---
 packages/next/pages/_document.js                 |  6 ++++++
 test/integration/amphtml/pages/custom-scripts.js | 13 +++++++++++++
 test/integration/amphtml/test/index.test.js      |  6 ++++++
 3 files changed, 25 insertions(+)
 create mode 100644 test/integration/amphtml/pages/custom-scripts.js
diff --git a/packages/next/pages/_document.js b/packages/next/pages/_document.js
index 5a5482ba899ce..4e84f6365553d 100644
--- a/packages/next/pages/_document.js
+++ b/packages/next/pages/_document.js
@@ -186,6 +186,12 @@ export class Head extends Component {
         badProp = 'name="viewport"'
       } else if (type === 'link' && props.rel === 'canonical') {
         badProp = 'rel="canonical"'
+      } else if (type === 'script') {
+        badProp = '<script'
+        Object.keys(props).forEach(prop => {
+          badProp += ` ${prop}="${props[prop]}"`
+        })
+        badProp += '/>'
       }
 
       if (badProp) {
diff --git a/test/integration/amphtml/pages/custom-scripts.js b/test/integration/amphtml/pages/custom-scripts.js
new file mode 100644
index 0000000000000..a2769d1e977f3
--- /dev/null
+++ b/test/integration/amphtml/pages/custom-scripts.js
@@ -0,0 +1,13 @@
+import Head from 'next/head'
+
+export default () => (
+  <div>
+    <Head>
+      <script src='/im-not-allowed.js' type='text/javascript' />
+      <script dangerouslySetInnerHTML={{
+        __html: `console.log("I'm not either :p")`
+      }} />
+    </Head>
+    <p>We only allow AMP scripts now</p>
+  </div>
+)
diff --git a/test/integration/amphtml/test/index.test.js b/test/integration/amphtml/test/index.test.js
index 7b5d95c45b084..1cfcc76e966b2 100644
--- a/test/integration/amphtml/test/index.test.js
+++ b/test/integration/amphtml/test/index.test.js
@@ -107,6 +107,12 @@ describe('AMP Usage', () => {
         'amp-boilerplate'
       ])
     })
+
+    it('should drop custom scripts', async () => {
+      const html = await renderViaHTTP(appPort, '/custom-scripts')
+      expect(html).not.toMatch(/src='\/im-not-allowed\.js'/)
+      expect(html).not.toMatch(/console\.log("I'm not either :p")'/)
+    })
   })
 
   describe('With AMP context', () => {
