From 18b12a176f9f21c6f4f41a42e5b864720af8c77a Mon Sep 17 00:00:00 2001 From: Dan Zajdband Date: Sat, 15 Oct 2016 13:04:20 -0400 Subject: [PATCH 1/4] Open tab when running next dev --- bin/next-dev | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/bin/next-dev b/bin/next-dev index 34b6c7583ac77..b6a68fa7c551d 100755 --- a/bin/next-dev +++ b/bin/next-dev @@ -1,6 +1,7 @@ #!/usr/bin/env node import { resolve } from 'path' +import { exec } from 'child_process' import parseArgs from 'minimist' import Server from '../server' import build from '../server/build' @@ -16,6 +17,12 @@ const argv = parseArgs(process.argv.slice(2), { } }) +const open = url => { + const openers = { darwin: 'open', win32: 'start' } + const cmdName = openers[process.platform] || 'xdg-open' + exec(`${cmdName} ${url}`) +} + const dir = resolve(argv._[0] || '.') build(dir) @@ -23,6 +30,7 @@ build(dir) const srv = new Server({ dir, dev: true }) await srv.start(argv.port) console.log('> Ready on http://localhost:%d', argv.port); + open(`http://localhost:${argv.port}`) }) .catch((err) => { console.error(err) From 868f48aceb28aeaf01d863b0941cc7b4d8d52865 Mon Sep 17 00:00:00 2001 From: Dan Zajdband Date: Sun, 16 Oct 2016 19:03:35 -0400 Subject: [PATCH 2/4] Added NEXT_OPEN_BROWSER env var to prevent open a browser tab on next dev --- bin/next-dev | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/bin/next-dev b/bin/next-dev index b6a68fa7c551d..06f5ce29795c5 100755 --- a/bin/next-dev +++ b/bin/next-dev @@ -29,8 +29,11 @@ build(dir) .then(async () => { const srv = new Server({ dir, dev: true }) await srv.start(argv.port) - console.log('> Ready on http://localhost:%d', argv.port); - open(`http://localhost:${argv.port}`) + console.log('> Ready on http://localhost:%d', argv.port) + + if (['false', '0'].indexOf(process.env.NEXT_OPEN_BROWSER) === -1) { + open(`http://localhost:${argv.port}`) + } }) .catch((err) => { console.error(err) From d75277670a469c4ceef178fb7a744a51932f29b5 Mon Sep 17 00:00:00 2001 From: Dan Zajdband Date: Sun, 16 Oct 2016 21:37:43 -0400 Subject: [PATCH 3/4] using regexp for testing false on env var --- bin/next-dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/next-dev b/bin/next-dev index e15cba67b0c64..d47af1718c7ad 100755 --- a/bin/next-dev +++ b/bin/next-dev @@ -40,7 +40,7 @@ build(dir) } } - if (['false', '0'].indexOf(process.env.NEXT_OPEN_BROWSER) === -1) { + if (/^(false|0)$/i.test(process.env.NEXT_OPEN_BROWSER)) { open(`http://localhost:${argv.port}`) } }) From ed6f90041235780de642539754f3c96ff47d39a4 Mon Sep 17 00:00:00 2001 From: Dan Zajdband Date: Sun, 16 Oct 2016 21:43:33 -0400 Subject: [PATCH 4/4] adding ! to if --- bin/next-dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/next-dev b/bin/next-dev index d47af1718c7ad..6e9dc8f5a1aa3 100755 --- a/bin/next-dev +++ b/bin/next-dev @@ -40,7 +40,7 @@ build(dir) } } - if (/^(false|0)$/i.test(process.env.NEXT_OPEN_BROWSER)) { + if (!/^(false|0)$/i.test(process.env.NEXT_OPEN_BROWSER)) { open(`http://localhost:${argv.port}`) } })