Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should handle font-size correctly for element like heading #452

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

Jackie1210
Copy link
Contributor

@Jackie1210 Jackie1210 commented Apr 20, 2023

Close #392
Close #254

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 1:29pm

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! — the reason that we use small test snapshots (100x100) is to keep the repository small.

@shuding
Copy link
Member

shuding commented Apr 20, 2023

Oops, why was this closed?

@Jackie1210
Copy link
Contributor Author

@shuding hhh I just want to refine code later. I will finish it as soon as i am home.Just off work.

@Jackie1210
Copy link
Contributor Author

@shuding Hi! shuding. I've reopened this PR. Now you can check again~ thanks!

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuding shuding merged commit 16d8b99 into vercel:main Apr 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 0.4.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jackie1210 Jackie1210 deleted the fix/h-font-size branch April 21, 2023 01:05
sahithyandev pushed a commit to sahithyandev/satori that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heading element font-size in em/rem not applied Heading elements have incorrect font size
2 participants