refactor: gradient & support more degree unit #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuding
pushed a commit
that referenced
this pull request
Sep 14, 2024
Now that #624 has been merged, let me bring`repeating-linear-gradient` to satori~ ❤️ Close #554 Note about the algorithm: <hr> Option 1: `0 < deg < 90` define ```math r=(h/w)^2 ``` then, calculate the intersection point of the last two lines ```math y = - r / tan(angle) ·x + w / 2 + h/2+r·w/ (2·tan(angle)) ``` ```math y=tan(angle) ·x + h ``` Finally, we can get `(x1, y1)`, `(x2, y2)` about length: ```math y = - 1 / tan(angle) ·x + w / 2 + h/2+r·w/ (2·tan(angle)) ``` ```math y=tan(angle) ·x + h ``` then, we can get a point: `(a, b)`, so length is $`2 ·\sqrt{(a - w/2)^2 + (b - h/2)^2}`$ <hr> Option 2: `90 < deg < 180` define ```math r=(h/w)^2 ``` then, calculate the intersection point of the last two lines ```math y = - r / tan(angle) ·x + w / 2 + h/2+r·w/ (2·tan(angle)) ``` ```math y=tan(angle) ·x ``` Finally, we can get `(x1, y1)`, `(x2, y2)` about length: ```math y = - 1 / tan(angle) ·x + w / 2 + h/2+r·w/ (2·tan(angle)) ``` ```math y=tan(angle) ·x ``` then, we can get a point: `(a, b)`, so length is $`2 ·\sqrt{(a - w/2)^2 + (b - h/2)^2}`$ Actually, I didn't find any spec of the algorithm on calculating the points. I just came across the algorithm accidentally. It turns out it shows the same result just like chrome renders.
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on implementing
repeating-linear-gradient, but I think we should refactor logic here at first for future.turn,rad,gradinlinear-gradientFix #581 (comment)
Fix #581 (comment)