fix(turborepo): Handle unimplemented and failed_precondition in daemo…

…n clients (#5151) Co-authored-by: Greg Soltis <Greg Soltis>
vercel · May 31, 2023 · f2ae81a · f2ae81a
1 parent 901c4a3
commit f2ae81a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/cli/internal/daemon/connector/connector.go b/cli/internal/daemon/connector/connector.go
@@ -329,6 +329,8 @@ func (c *Connector) sendHello(ctx context.Context, client turbodprotocol.TurbodC
 	switch status.Code() {
 	case codes.OK:
 		return nil
+	case codes.Unimplemented:
+		fallthrough // some versions of the rust daemon return Unimplemented rather than FailedPrecondition
 	case codes.FailedPrecondition:
 		return ErrVersionMismatch
 	case codes.Unavailable:

diff --git a/crates/turborepo-lib/src/daemon/client.rs b/crates/turborepo-lib/src/daemon/client.rs
@@ -160,7 +160,7 @@ pub enum DaemonError {
 impl From<Status> for DaemonError {
     fn from(status: Status) -> DaemonError {
         match status.code() {
-            Code::FailedPrecondition => DaemonError::VersionMismatch,
+            Code::FailedPrecondition | Code::Unimplemented => DaemonError::VersionMismatch,
             Code::Unavailable => DaemonError::Unavailable,
             c => DaemonError::GrpcFailure(c),
         }

diff --git a/crates/turborepo-lib/src/daemon/server.rs b/crates/turborepo-lib/src/daemon/server.rs
@@ -218,8 +218,13 @@ impl<T: Watcher + Send + 'static> proto::turbod_server::Turbod for DaemonServer<
         &self,
         request: tonic::Request<proto::HelloRequest>,
     ) -> Result<tonic::Response<proto::HelloResponse>, tonic::Status> {
-        if request.into_inner().version != get_version() {
-            return Err(tonic::Status::unimplemented("version mismatch"));
+        let client_version = request.into_inner().version;
+        let server_version = get_version();
+        if client_version != server_version {
+            return Err(tonic::Status::failed_precondition(format!(
+                "version mismatch. Client {} Server {}",
+                client_version, server_version
+            )));
         } else {
             Ok(tonic::Response::new(proto::HelloResponse {}))
         }