-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Middleware Routing #3930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 639b4d5
Click to view full benchmark
|
jridgewell
changed the title
Extract middleware matcher config
Update Middleware Routing
Feb 25, 2023
In order to setup the middleware in routing, we need to know what routes to match on without executing the middleware edgeInfo itself.
jridgewell
force-pushed
the
jrl-middleware-config
branch
from
February 25, 2023 02:15
bbc4543
to
24e02cc
Compare
Benchmark for a054105Click to view benchmark
|
sokra
approved these changes
Feb 27, 2023
jridgewell
added
the
pr: automerge
Kodiak will merge these automatically after checks pass
label
Feb 27, 2023
Benchmark for 4cce076
Click to view full benchmark
|
Benchmark for f8afd01Click to view benchmark
|
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 1, 2023
# New Features - vercel/turborepo#3930 # Misc Changes - vercel/turborepo#3944 - vercel/turborepo#3774
ijjk
added a commit
to vercel/next.js
that referenced
this pull request
Mar 1, 2023
This implements middleware support for Turbopack's route resolver. In vercel/turborepo#3930, I'm updating the data that we pass to include a new `MiddlewareConfig`, which includes the files needed for invoking the edge function and the matchers extracted from the middleware's static `export config = {}`. ~~This needs to wait for vercel/turborepo#3930 to land first~~ Merged. Fixes https://linear.app/vercel/issue/WEB-624 --------- Co-authored-by: JJ Kasper <jj@jjsweb.site>
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This accomplishes 2 things: - Moves the creation of the edge info onto the Next.js side - Extracts the middleware's `export const config = {}`, so that we can know what matchers are needed before invoking the edge function definition. After this, an update to the Next.js side will enable middleware. Fixes WEB-623
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This accomplishes 2 things: - Moves the creation of the edge info onto the Next.js side - Extracts the middleware's `export const config = {}`, so that we can know what matchers are needed before invoking the edge function definition. After this, an update to the Next.js side will enable middleware. Fixes WEB-623
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This accomplishes 2 things: - Moves the creation of the edge info onto the Next.js side - Extracts the middleware's `export const config = {}`, so that we can know what matchers are needed before invoking the edge function definition. After this, an update to the Next.js side will enable middleware. Fixes WEB-623
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This accomplishes 2 things: - Moves the creation of the edge info onto the Next.js side - Extracts the middleware's `export const config = {}`, so that we can know what matchers are needed before invoking the edge function definition. After this, an update to the Next.js side will enable middleware. Fixes WEB-623
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This accomplishes 2 things: - Moves the creation of the edge info onto the Next.js side - Extracts the middleware's `export const config = {}`, so that we can know what matchers are needed before invoking the edge function definition. After this, an update to the Next.js side will enable middleware. Fixes WEB-623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accomplishes 2 things:
export const config = {}
, so that we can know what matchers are needed before invoking the edge function definition.After this, an update to the Next.js side will enable middleware.
Fixes WEB-623