fix(build): error on types for fs callback

verdaccio · Aug 13, 2019 · cc35acb · cc35acb
1 parent 7f755fa
commit cc35acb
Show file tree

Hide file tree

Showing 3 changed files with 383 additions and 655 deletions.
diff --git a/plugins/local-storage/package.json b/plugins/local-storage/package.json
@@ -5,7 +5,7 @@
   "main": "lib/index.js",
   "scripts": {
     "release": "standard-version -a -s",
-    "test": "npm run lint && jest",
+    "test": "jest",
     "lint": "eslint . --ext .js,.ts",
     "commitmsg": "commitlint -e $GIT_PARAMS",
     "type-check": "tsc --noEmit",

diff --git a/plugins/local-storage/src/local-fs.ts b/plugins/local-storage/src/local-fs.ts
@@ -16,6 +16,8 @@ export const noSuchFile = 'ENOENT';
 export const resourceNotAvailable = 'EAGAIN';
 export const pkgFileName = 'package.json';
 
+type CallbackFS = NodeJS.ErrnoException | null;
+
 export const fSError = function(message: string, code: number = 409): HttpError {
   const err: HttpError = createError(code, message);
   // $FlowFixMe
@@ -127,11 +129,11 @@ export default class LocalFS implements ILocalFSPackageManager {
     });
   }
 
-  deletePackage(fileName: string, callback: CallbackError) {
+  deletePackage(fileName: string, callback: (err: NodeJS.ErrnoException | null) => void) {
     return fs.unlink(this._getStorage(fileName), callback);
   }
 
-  removePackage(callback: CallbackError): void {
+  removePackage(callback: (err: NodeJS.ErrnoException | null) => void): void {
     fs.rmdir(this._getStorage('.'), callback);
   }