Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auth callback TS types #225

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Improve auth callback TS types #225

merged 2 commits into from
Oct 26, 2019

Conversation

n4bb12
Copy link
Contributor

@n4bb12 n4bb12 commented Oct 26, 2019

Type:

typescript

Scope:

types

Description:

Adds a bit more validation for auth callbacks.
See https://verdaccio.org/docs/en/dev-plugins#callback for reference.

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files          26       26           
  Lines        1401     1401           
  Branches      201      201           
=======================================
  Hits          917      917           
  Misses        482      482           
  Partials        2        2
Flag Coverage Δ
#core 88.18% <ø> (ø) ⬆️
#plugins 58.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b66af...9eef821. Read the comment docs.

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this 👍

@juanpicado juanpicado merged commit ee442a0 into verdaccio:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants