Allow endpoint to be configurable #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently a new feature ws introduced to allow passing the configuration values through environment variables only this didn't cover the `endpoint`-config this PR adds supports for defining the S3 Endpoint in the environment variables.
|
If you updated the README would be perfect 👍 |
Added call out that `endpoint` is also supported for the environment variables
|
@juanpicado Done :) |
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 70.42% 70.37% -0.05%
==========================================
Files 28 28
Lines 1420 1421 +1
Branches 204 207 +3
==========================================
Hits 1000 1000
Misses 418 418
- Partials 2 3 +1
Continue to review full report at Codecov.
|
|
Thanks @weyert great stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a new feature was introduced to allow passing the configuration values through environment variables only this didn't cover the
endpoint-config this PR adds supports for defining the S3 Endpoint in the environment variables.