You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Through reviewing #45, I've discovered a bug in the current implementation of the mirror. The problematic aspect is as follows:
_validate_packages can remove packages on disk that exist in the local repodata.json file
The local repodata.json file is not updated before that problematic file is removed
This means that a user of the condaserver can ask for a package that conda thinks it has (since it is still in repodata.json) but that it can't find (because it's been removed from disk)
As such, this code needs to be changed so that
_validate_packages returns a list of packages to remove
a new dict of package metadata is created that does not contain the packages that we are going to remove
That new package metadata dict is written to disk as an atomic operation
The problematic files are removed
With the above changes we will reduce the chance that the user will encounter an error from conda saying that the file cannot be found on the conda server. This is not a blocking issue on getting this PR merged. I'll fix this problem in a follow-on PR
The text was updated successfully, but these errors were encountered:
Through reviewing #45, I've discovered a bug in the current implementation of the mirror. The problematic aspect is as follows:
_validate_packages
can remove packages on disk that exist in the local repodata.json fileAs such, this code needs to be changed so that
_validate_packages
returns a list of packages to removeWith the above changes we will reduce the chance that the user will encounter an error from conda saying that the file cannot be found on the conda server. This is not a blocking issue on getting this PR merged. I'll fix this problem in a follow-on PR
The text was updated successfully, but these errors were encountered: