-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[account-web-vault]: Modal CSS conflicts with bootstrap css #237
Comments
While going through ShinzoHiro#3741 observation concerning this error from the discord channel // Hidden attribute
//
// Always hide an element with the `hidden` HTML attribute.
[hidden] {
display: none !important;
}
Removing the What are your thoughts on this? |
@cmcWebCode40 Sorry, I don't understand your question. Do you have a proposed code change to review that fixes the problem? |
After discussion, this ("Removing the hidden attribute in the parent modal div from the account-web-vault") seems like a good solution. @cmcWebCode40 will do a PR. |
|
Problem
The connect modal does not display when the package is used in a js framework set up with bootstrap CSS, this happens as a result of CSS conflict when the
bootstrap/dist/css/bootstrap.min.css
is importedsee the discord thread of the observation :
https://discord.com/channels/664594912460668960/1026461094421729340/1028925314300129330
cc @nick-verida @tahpot
The text was updated successfully, but these errors were encountered: