Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[account-web-vault]: Modal CSS conflicts with bootstrap css #237

Open
cmcWebCode40 opened this issue Oct 10, 2022 · 4 comments · May be fixed by #240
Open

[account-web-vault]: Modal CSS conflicts with bootstrap css #237

cmcWebCode40 opened this issue Oct 10, 2022 · 4 comments · May be fixed by #240

Comments

@cmcWebCode40
Copy link
Contributor

Problem

The connect modal does not display when the package is used in a js framework set up with bootstrap CSS, this happens as a result of CSS conflict when the bootstrap/dist/css/bootstrap.min.css is imported

see the discord thread of the observation :
https://discord.com/channels/664594912460668960/1026461094421729340/1028925314300129330

cc @nick-verida @tahpot

@cmcWebCode40
Copy link
Contributor Author

@tahpot,

While going through ShinzoHiro#3741 observation concerning this error from the discord channel
I could see where bootstrap defined this global CSS rule which overrides the hidden attribute set in our account vault modal

// Hidden attribute
//
// Always hide an element with the `hidden` HTML attribute.

[hidden] {
  display: none !important;
}

Removing the hidden attribute in the parent modal div from the account-web-vault packages resolves this because the parent div with class name verida-modal-wrapper has its initial display set to none .

What are your thoughts on this?

cc @nick-verida @aurelticot

@tahpot
Copy link
Member

tahpot commented Oct 11, 2022

@cmcWebCode40 Sorry, I don't understand your question.

Do you have a proposed code change to review that fixes the problem?

@nick-verida
Copy link
Contributor

After discussion, this ("Removing the hidden attribute in the parent modal div from the account-web-vault") seems like a good solution. @cmcWebCode40 will do a PR.

@cmcWebCode40
Copy link
Contributor Author

@cmcWebCode40 Sorry, I don't understand your question.

Do you have a proposed code change to review that fixes the problem?

@taphot I have opened a PR that fixes the issue here #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants