Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new rule no-import-node-test #317

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Dec 10, 2023

It was so annoying to me that VS Code often auto inserts the import from node:test when I type describe or test. It's might also hard to spot and found the bug. I think when ppl using Vitest, they are very unlikely to use node:test together. Having this rule allow the import to node:test always been fixed to vitest

Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@veritem veritem merged commit ccd7e88 into vitest-dev:main Dec 11, 2023
@veritem
Copy link
Member

veritem commented Dec 11, 2023

I'm thinking of making this a recommended rule since not many people will remember to turn it on when using package. Having it will reduce headache.

@antfu antfu deleted the feat/no-import-node-test branch December 11, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants