fix(vitest/no-done-callback): do not report when inside concurrent describe #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I updated the rule to no report when the local Test Context is used inside a test that is inside a concurrent describe block.
Why?
The current implementation reported a false-positive when the scenario described above exists.
How?
The rule goes up its ancestors and checks if it's inside a concurrent test or describe block.
Testing?
You can run the unit tests to check if the rule works. To check that on your local machine:
vitest/no-done-callback
)You will not see any linting error as long as the describe block has its
.concurrent
annotation. Once that gets removed the error will appear.