Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ubuntu-24.04 in CI #1441

Closed
ibc opened this issue Aug 9, 2024 · 8 comments · Fixed by #1440
Closed

Include ubuntu-24.04 in CI #1441

ibc opened this issue Aug 9, 2024 · 8 comments · Fixed by #1440
Assignees
Milestone

Comments

@ibc
Copy link
Member

ibc commented Aug 9, 2024

ubuntu-24.04 is already available: actions/runner-images#9848

Let's add it in all our CI actions.

@ibc ibc added the enhancement label Aug 9, 2024
@ibc ibc added this to the v3 updates milestone Aug 9, 2024
@ibc ibc self-assigned this Aug 9, 2024
@ibc
Copy link
Member Author

ibc commented Aug 9, 2024

Ironically we were already using ubuntu-24.04 in mediasoup-node.yaml but not in others. I've added them in this unrelated PR #1440 in commit 600ff04.

But amazingly it fails...

https://github.com/versatica/mediasoup/actions/runs/10319604062/job/28568334351?pr=1440

Ok, we must do same as we do for macos versions:

      # We need to install pip invoke manually.
      - if: runner.os != 'macOS'
        name: pip3 install invoke
        run: pip3 install invoke

      # In macOS we need to specify this option.
      - if: runner.os == 'macOS'
        name: pip3 install --break-system-packages invoke
        run: pip3 install --break-system-packages invoke

@nazar-pc
Copy link
Collaborator

nazar-pc commented Aug 9, 2024

Yes, on 24.04 they don't like you installing packages directly, see qtile/qtile#4804

@ibc
Copy link
Member Author

ibc commented Aug 9, 2024

NOTE: In mediasoup-worker-prebuild action I'm not gonna upgrade from ubuntu 22.04 to 24.04 to avoid same potential problem as this GLib related one:

#1089

@nazar-pc
Copy link
Collaborator

nazar-pc commented Aug 9, 2024

I believe by upgrading to 24.04 you'll make it impossible to use on older Ubuntu versions (and other distros) due to expecting newer Gibc version. So you should use the older version instead of newer.

@ibc
Copy link
Member Author

ibc commented Aug 9, 2024

I believe by upgrading to 24.04 you'll make it impossible to use on older Ubuntu versions (and other distros) due to expecting newer Gibc version. So you should use the older version instead of newer.

That's exactly what I said, yes :)

@nazar-pc
Copy link
Collaborator

nazar-pc commented Aug 9, 2024

But you said you're upgrading from 22.04 to even newer 24.04 🤔

@ibc
Copy link
Member Author

ibc commented Aug 9, 2024

In mediasoup-worker-prebuild action I'm not gonna upgrade from ubuntu 22.04 to 24.04 to avoid same potential problem as this GLib related one

I literally said in my previous comment:

In mediasoup-worker-prebuild action I'm not gonna upgrade from ubuntu 22.04 to 24.04 to avoid same potential problem as this GLib related one

😀

@nazar-pc
Copy link
Collaborator

nazar-pc commented Aug 9, 2024

I can't read today 🤦

@ibc ibc closed this as completed in #1440 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants