Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community feedback #7

Open
vietj opened this issue Dec 9, 2024 · 1 comment
Open

Community feedback #7

vietj opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@vietj
Copy link
Contributor

vietj commented Dec 9, 2024

eclipse-vertx/vert.x#5416

@vietj vietj added the enhancement New feature or request label Dec 9, 2024
@rzorzorzo
Copy link

Hello,

here some more changes I have found during the migration of an app from 4.x to 5.x:
Pls review this before publishing as there may be better ways of doing this.

routingContext.user() -> routingContext.user().get()

routingContext.clearUser() -> routingContext.user().clear()

routingContext.getBodyAsJson() -> routingContext.body().asJsonObject()

authProvider.authenticate(JsonObject, ... -> Credentials credentials = new JsonCredentials(authInfo);authProvider.authenticate(credentials);

StaticHandler.setWebRoot(webroot) -> StaticHandler.create(.., webroot)

routingContext.getBody().getBytes() -> routingContext.body().buffer().getBytes()

routingContext.setUser(vuser) -> ((UserContextInternal) routingContext.user()).setUser(vuser)

routingContext.request().host() -> routingContext.request().authority().host();

io.vertx.core.logging.Logger -> io.vertx.core.internal.logging.Logger
io.vertx.core.logging.LoggerFactory -> io.vertx.core.internal.logging.LoggerFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants