Add Scala to start.vertx.io #626
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-brm
commented
Dec 3, 2024
| @@ -292,7 +293,7 @@ private void verifyMavenFiles() { | |||
|
|
|||
| private void verifyMavenOutputFiles() throws IOException { | |||
| try (Stream<Path> pathStream = Files.walk(workdir)) { | |||
| Optional<Path> testResult = pathStream.filter(p -> p.toString().endsWith("TestMainVerticle.txt")).findFirst(); | |||
| Optional<Path> testResult = pathStream.filter(p -> p.toString().endsWith("TestMainVerticle.xml")).findFirst(); | |||
There was a problem hiding this comment.
@tsegismont ScalaTest does not generate *.txt files, except for the whole suite. To fix this, I had to change this predicate here, so it looks for the xml test report instead. I think this is also more consistent with verifyGradleOutputFiles().
There was a problem hiding this comment.
@tsegismont just in case you missed it... This PR is ready to be reviewed now. 🤞 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that we have
vertx-lang-scalain Maven Central, we could offer it via start.vertx.io!This is a follow-up from PR #624. It fixes the formatting changes I did back then.
This PR adds
Closes vert-x3/vertx-lang-scala#106
Closes vert-x3/vertx-lang-scala#105
Closes #118