Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I block the registration information for 'localOnly,' will there be any side effects?Or is it a bug? #148

Closed
goonover opened this issue Jul 22, 2023 · 4 comments

Comments

@goonover
Copy link

goonover commented Jul 22, 2023

Questions

In the code, io.vertx.spi.cluster.zookeeper.ZookeeperClusterManager#addRegistration.The method just call 'subsMapHelper.put(address, registrationInfo, promise);'.
As a result, there will be many nodes like '__vertx.net.fb433846-5f7f-4888-b8fd-4ef6a05825dc' in path '/io.vertx/__vertx.subs'.These ids should be generated by io.vertx.core.net.impl.NetSocketImpl#writeHandlerID.And when I debug, I found these registration is localOnly, why these registration info write to zookeeper

Version

4.0.4

@goonover goonover added the bug label Jul 22, 2023
@goonover
Copy link
Author

goonover commented Jul 22, 2023

Will there be any side effects I modify the addRegistration to

public void addRegistration(String address, RegistrationInfo registrationInfo, Promise promise) {
if (registrationInfo.localOnly()) {
return;
}
subsMapHelper.put(address, registrationInfo, promise);
}

@tsegismont
Copy link
Contributor

@goonover can you update to 4.4? writeHandlerIDs are disabled by default in this version (see eclipse-vertx/vert.x#4625)

@goonover
Copy link
Author

Yes, this problem can be sloved by updating version to 4.4.4

@tsegismont
Copy link
Contributor

Thanks for letting us know!

@tsegismont tsegismont added duplicate and removed bug labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants