-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ROOT to the pushforward/pullback model #510
Comments
Hello Vassil, To work on this issue, I have some doubts that I would like more information upon: ++ Does the root use CLAD latest version and has tests to check custom derivative? Thanks, |
Yes, it uses the last version of clad (v1.0).
No, and that's the issue, this part has no test coverage in ROOT but I think we should develop some basic tests after we migrate. |
This issue is independent on the release of Clad and thus not a release blocker. |
This has been resolved. Thanks a lot @arora-vidushi! |
Here, we need to move https://github.com/root-project/root/blob/master/math/mathcore/inc/Math/CladDerivator.h to follow what has been done in Clad: https://github.com/vgvassilev/clad/blob/master/include/clad/Differentiator/BuiltinDerivatives.h where all functions are based on pushforwards and pullbacks.
The text was updated successfully, but these errors were encountered: