Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ROOT to the pushforward/pullback model #510

Closed
vgvassilev opened this issue Nov 24, 2022 · 4 comments
Closed

Move ROOT to the pushforward/pullback model #510

vgvassilev opened this issue Nov 24, 2022 · 4 comments

Comments

@vgvassilev
Copy link
Owner

Here, we need to move https://github.com/root-project/root/blob/master/math/mathcore/inc/Math/CladDerivator.h to follow what has been done in Clad: https://github.com/vgvassilev/clad/blob/master/include/clad/Differentiator/BuiltinDerivatives.h where all functions are based on pushforwards and pullbacks.

@arora-vidushi
Copy link
Contributor

Hello Vassil,

To work on this issue, I have some doubts that I would like more information upon:

++ Does the root use CLAD latest version and has tests to check custom derivative?
++ Also, if we change the custom derivative function in Root, will it break the existing tests?

Thanks,
Vidushi

@vgvassilev
Copy link
Owner Author

vgvassilev commented Nov 28, 2022

Hello Vassil,

To work on this issue, I have some doubts that I would like more information upon:

++ Does the root use CLAD latest version and has tests to check custom derivative?

Yes, it uses the last version of clad (v1.0).

++ Also, if we change the custom derivative function in Root, will it break the existing tests?

No, and that's the issue, this part has no test coverage in ROOT but I think we should develop some basic tests after we migrate.

@vgvassilev
Copy link
Owner Author

This issue is independent on the release of Clad and thus not a release blocker.

@vgvassilev vgvassilev removed this from the v1.1 milestone Jan 20, 2023
@vgvassilev
Copy link
Owner Author

This has been resolved. Thanks a lot @arora-vidushi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants