enhancement/required-account-fields #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victorbalssa
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Thank you @br0tda!
I like the idea, can you update the suggestions so I can deploy this in the next minor version?
Co-authored-by: victorbalssa <victor.balssa@gmail.com>
Co-authored-by: victorbalssa <victor.balssa@gmail.com>
|
Code updated. Thank you! |
victorbalssa
approved these changes
Feb 21, 2024
victorbalssa
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to mark as required src/dst account based on transaction type
name: Pull request
about: AutocompleteField isRequired attribute
title: Logic for required account fields
labels: feature
assignees: victorbalssa
Is your feature request related to a problem? Please describe.
Currently, the source account is always marked as required, even in a 'deposit' transaction
Describe the solution you'd like
The source account is marked as required only in 'withdrawal' or 'transfer' transaction.
The destination account is marked as required only in 'deposit' or 'transfer' transaction.
Describe alternatives you've considered
...
Additional context
...