Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overlapping appends on start not present in v1.4.x #6471

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Don't append over first fragment when next fragment aligns with playlist within 1/200s tolerance.

Why is this Pull Request needed?

Fixes edge-case starting in v1.5 that causes #6441

Are there any points in the code the reviewer needs to double check?

The 1/200s magic number is a temporary workaround. We may make this configurable in future releases, but it can be masked completely by maxFragLookupTolerance.

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…ist within 1/200s tolerance

Fixes edge-case starting in v1.5 that causes #6441
@robwalch robwalch added this to the 1.5.10 milestone May 31, 2024
@robwalch robwalch merged commit e1c2904 into patch/v1.5.x Jun 1, 2024
14 of 15 checks passed
@robwalch robwalch deleted the bugfix/dont-overlap-first-on-next-up branch June 1, 2024 00:31
robwalch added a commit that referenced this pull request Jun 1, 2024
* patch/v1.5.x:
  Don't append over first fragment when next fragment aligns with playlist within 1/200s tolerance (#6471)
  Fix exception reading metadata.channelCount with HE-AAC when changeType is not supported (#6472)
  Fix TSDemuxer parsing error handling in sync path (#6469)
  when `this.stats` is called, add optional chaining or check for existence (#6459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant