bin/build: speed-up local build time #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we have GOPATH defined, we probably have the dependencies, than we don't need to download them again. It still works as expected in a box with no GOPATH defined. It's way faster to avoid downloading the dependencies. This is because `go get` is dumb when cloning Git repositories. This should probably change when golang/go#13078 is fixed (Go 1.7, hopefully).
|
LGTM |
marzagao
added a commit
that referenced
this pull request
Feb 24, 2016
bin/build: speed-up local build time
|
Nice, the reason there was a tmp dir there before was because I envisioned this running on a CI server. Even if it does, ideally there will be a cache volume. This is a good thing to test when we setup drone. 👍 |
|
@balser yes, definitely. We could probably have the volume cached from the job that run the tests, since we need to download the dependencies for running the tests. Then we set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we have GOPATH defined, we probably have the dependencies, than
we don't need to download them again. It still works as expected in a
box with no GOPATH defined.
It's way faster to avoid downloading the dependencies. This is because
go getis dumb when cloning Git repositories. This should probablychange when golang/go#13078 is fixed (Go 1.7, hopefully).