Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dont run tests on chromium #1116

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Conversation

brandonocasey
Copy link
Contributor

Description

We can really run our tests in chromium as we require basic media types to be supported, which chromium does not support.

@brandonocasey brandonocasey changed the title chore: uninstall chromimum browser on ubuntu chore: dont run tests on chromium Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1116 (d20b6eb) into main (684fd08) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files          38       38           
  Lines        9068     9068           
  Branches     2052     2052           
=======================================
  Hits         7825     7825           
  Misses       1243     1243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684fd08...d20b6eb. Read the comment docs.

@brandonocasey brandonocasey merged commit c2154d7 into main Apr 8, 2021
@brandonocasey brandonocasey deleted the chore/remove-chromium branch April 8, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants