fix: remove segment loader abort in setCurrentTime #1415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the
abort
call fromsetCurrentTime
makes seeking and certain playlist switching cases more resilient. This is becausesetCurrentTime
was essentially calling abort on all the segment loaders twice. Once in thesetCurrentTime
function directly, then fromresetEverything
which eventually callsresyncLoader
which also callsabort
on the segment loader.Specific Changes proposed
Remove the
abort
calls on all segment loaders and fix the tests.Requirements Checklist