Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request Content Steering manifest #1419

Merged
merged 36 commits into from
Aug 30, 2023
Merged

feat: request Content Steering manifest #1419

merged 36 commits into from
Aug 30, 2023

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Aug 16, 2023

Description

This is the first step toward full content steering support in VHS. This pull request will add the ContentSteeringController class which will allow VHS to parse content steering tags from both the m3u8 and mpd parsers, request and parse a content steering manifest, and listen to events from the content-steering-controller that will notify VHS of changes in content steering data.

Specific Changes proposed

Adding a new ContentSteeringController class that will likely live in the playback-controller, parsing content steering tags as they appear in the main manifest. Also requesting the steering manifest when required, and reacting to changes in the steering manifest and playback state.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@adrums86 adrums86 self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1419 (1326a15) into main (c246ca1) will increase coverage by 0.16%.
The diff coverage is 99.21%.

@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   85.58%   85.75%   +0.16%     
==========================================
  Files          41       42       +1     
  Lines       10156    10284     +128     
  Branches     2352     2374      +22     
==========================================
+ Hits         8692     8819     +127     
- Misses       1464     1465       +1     
Files Changed Coverage Δ
src/content-steering-controller.js 99.21% <99.21%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrums86 adrums86 marked this pull request as ready for review August 30, 2023 04:40
Copy link
Contributor

@wseymour15 wseymour15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! +1 after question is resolved

@adrums86 adrums86 merged commit 86d5327 into main Aug 30, 2023
14 checks passed
@adrums86 adrums86 deleted the feat-ContentSteering branch August 30, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants