-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: request Content Steering manifest #1419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 85.58% 85.75% +0.16%
==========================================
Files 41 42 +1
Lines 10156 10284 +128
Branches 2352 2374 +22
==========================================
+ Hits 8692 8819 +127
- Misses 1464 1465 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wseymour15
reviewed
Aug 30, 2023
wseymour15
reviewed
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! +1 after question is resolved
wseymour15
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step toward full content steering support in VHS. This pull request will add the
ContentSteeringController
class which will allow VHS to parse content steering tags from both the m3u8 and mpd parsers, request and parse a content steering manifest, and listen to events from the content-steering-controller that will notify VHS of changes in content steering data.Specific Changes proposed
Adding a new
ContentSteeringController
class that will likely live in the playback-controller, parsing content steering tags as they appear in the main manifest. Also requesting the steering manifest when required, and reacting to changes in the steering manifest and playback state.Requirements Checklist