Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/clear blacklist #479

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Fix/clear blacklist #479

merged 3 commits into from
Apr 26, 2019

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Apr 25, 2019

Description

This code is from #396 / 6e6c8c2, which was reverted in #471 / dd55028 I added a fix so that it does not break live playback but still completes its intended goal of clearing blacklists for other playlists if the final rendition errors.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, basically, use a different timer so that regular media updates aren't affected when we're on the final playlist?

src/playlist-loader.js Show resolved Hide resolved
@brandonocasey
Copy link
Contributor Author

Yeah I tried keeping it using mediaUpdateTimeout for awhile and did get something working, but the fix made things more complex to understand than using another timer.

@gkatsev
Copy link
Member

gkatsev commented Apr 25, 2019

Yeah, makes it a lot simpler. For a while I didn't even realize you made a change until I went looking through the commits directly 😆.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this doesn't break live streams.

@gkatsev gkatsev merged commit fe3b378 into master Apr 26, 2019
@gkatsev gkatsev deleted the fix/clear-blacklist branch April 26, 2019 18:20
brandonocasey added a commit that referenced this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants