Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: support multiple stream-inf with same URI #672

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Conversation

mjneil
Copy link
Contributor

@mjneil mjneil commented Oct 10, 2019

Description

Fixes #663

backport of #670

Specific Changes proposed

Instead of using playlist URI as a unique identifier for streams, create an id property that is the combination of uri and index within the master manifest.

* support multiple stream-inf with same URI

* fix existing tests

* add unit test
@gkatsev
Copy link
Member

gkatsev commented Oct 10, 2019

Marked as blocked because @mjneil realized that this could potentially be a breaking change.

@mjneil mjneil removed the blocked label Nov 5, 2019
@gkatsev gkatsev merged commit 095515c into 1.x Dec 6, 2019
@gkatsev gkatsev deleted the issue/663-1.x branch December 6, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants