fix: trim 30s back from playhead even for VOD and LIVE DVR content #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the seekable window for the content started at 0 (generally denoting a VOD or LIVE DVR playlist), the back buffer would not be trimmed. With high bitrate and/or longer content, this could lead to an APPEND_BUFFER_ERR due to the buffer exceeding the max allowed buffered bytes. In order to help alleviate this issue, particularly with the increase in high bitrate content, the back buffer is now trimmed to a reasonable length, even if the seekable window starts at 0.
gkatsev
approved these changes
Feb 18, 2020
gesinger
added a commit
to gesinger/http-streaming
that referenced
this pull request
Feb 19, 2020
…ideojs#740) Previously, if the seekable window for the content started at 0 (generally denoting a VOD or LIVE DVR playlist), the back buffer would not be trimmed. With high bitrate and/or longer content, this could lead to an APPEND_BUFFER_ERR due to the buffer exceeding the max allowed buffered bytes. In order to help alleviate this issue, particularly with the increase in high bitrate content, the back buffer is now trimmed to a reasonable length, even if the seekable window starts at 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the seekable window for the content started at 0
(generally denoting a VOD or LIVE DVR playlist), the back buffer would
not be trimmed. With high bitrate and/or longer content, this could
lead to an APPEND_BUFFER_ERR due to the buffer exceeding the max
allowed buffered bytes.
In order to help alleviate this issue, particularly with the increase in
high bitrate content, the back buffer is now trimmed to a reasonable
length, even if the seekable window starts at 0.
Requirements Checklist