fix: null check return value of selectPlaylist #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Mar 23, 2020
src/master-playlist-controller.js
Outdated
| // ensure we have some buffer before we switch up to prevent us running out of | ||
| // buffer while loading a higher rendition. | ||
| forwardBuffer >= bufferLowWaterLine) { | ||
| if (nextPlaylist && |
There was a problem hiding this comment.
It may be worth having a message being logged somewhere (maybe even as a warning) in this case. Will make debugging easier if we ever run into it.
This implemention mirrors the original if statement. This is becasuse if it were to invert it, it would actually end the chain too early. Thus, we return true This is because if were to invert it, we actually would end too early in the checks chain.
|
note 70ad314 |
gesinger
reviewed
Mar 23, 2020
gesinger
reviewed
Mar 23, 2020
| this.masterPlaylistController.mainSegmentLoader_.trigger('bandwidthupdate'); | ||
| assert.strictEqual(calls, 3, 'selects after additional segments'); | ||
| // verify stats | ||
| assert.equal(this.player.tech_.hls.stats.bandwidth, 4194304, 'default bandwidth'); |
There was a problem hiding this comment.
I think we can remove this.
There was a problem hiding this comment.
I kept it because it's literally a copy and paste from the above test but I guess we can remove it.
brandonocasey
approved these changes
Mar 24, 2020
gkatsev
added a commit
that referenced
this pull request
Mar 24, 2020
This is #779 but against master.
gkatsev
added a commit
that referenced
this pull request
Mar 24, 2020
This is #779 but against master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.