fix: use playlist NAME when available as its ID #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test and briefly reverting the previous changes to show that the test fails. Once travis shows the failure I'll bring the changes back. |
brandonocasey
previously approved these changes
Sep 10, 2020
gesinger
reviewed
Sep 21, 2020
src/dash-playlist-loader.js
Outdated
| @@ -43,7 +43,7 @@ export const parseMasterXml = ({ masterXml, srcUrl, clientOffset, sidxMapping }) | |||
| sidxMapping | |||
| }); | |||
|
|
|||
| addPropertiesToMaster(master, srcUrl); | |||
| addPropertiesToMaster(master, srcUrl, 'dash'); | |||
There was a problem hiding this comment.
I think this should be true instead of 'dash'
There was a problem hiding this comment.
oops, I made the change locally but apparently forgot to save.
brandonocasey
approved these changes
Sep 23, 2020
gkatsev
added a commit
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly used in DASH as the
NAMEis set from the Representation'sIDwhich is specified to be unique per period and that across periods, the representations with the same ID should be functionally equivalent.This is important because in DASH, across periods, it's possible for Representations to be re-ordered, and we want to make sure that the reference doesn't get messed up when the period updates.
It still sets up a reference to the playlist via the old name but if the ordering is changed it'll reference the incorrect playlist as it does now.
TODO