Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add experimental support for ManagedMediaSource #1453

Merged
merged 14 commits into from
Aug 23, 2024

Conversation

mister-ben
Copy link
Contributor

Adds basic support for ManagedMediaSource. Must be enabled with the useManagedMediaSource VHS option.

Does not implement an alternate AirPlay source - this requires a more significant change, to add two source els. This means remote playback has to be disabled on the video el when using MMS.

Event listeners for advanced control are not yet implemented - startstreaming, endstreaming, qualitychange

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.36%. Comparing base (dba1b79) to head (f700a8e).
Report is 1 commits behind head on main.

Files Patch % Lines
src/videojs-http-streaming.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage   86.36%   86.36%   -0.01%     
==========================================
  Files          43       43              
  Lines       11144    11151       +7     
  Branches     2545     2548       +3     
==========================================
+ Hits         9625     9631       +6     
- Misses       1519     1520       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title feat: Add support for ManagedMediaContoller feat: Add support for ManagedMediaSource Nov 29, 2023
@mister-ben
Copy link
Contributor Author

Adding as <source> children instead of the src attribute could be done here. We would need to ensure both the attribute and <source> children are removed on source changes, including to or from non-VHS sources. Also, will anything else expect the src attribute to be present?

@snowinszu
Copy link

Hi, any news?

@mister-ben mister-ben marked this pull request as ready for review July 1, 2024 15:09
@mister-ben mister-ben added the minor Can be merged into a minor / feat release label Jul 22, 2024
@mister-ben mister-ben changed the title feat: Add support for ManagedMediaSource feat: Add experimental support for ManagedMediaSource Aug 23, 2024
index.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Can be merged into a minor / feat release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants