Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio segment on incorrect timeline HLS #1539

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

wseymour15
Copy link
Contributor

Description

Related to #1530

This fixes an issue that was previously thought to just happen in DASH above. Now, in HLS, if the audio segment in on a previous timeline to the video segment, we will push playback to where they are both on the same timeline.

Specific Changes proposed

  • Removes the DASH safeguards in the audio segment behind timeline logic so this covers HLS as well.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@wseymour15 wseymour15 self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (96a3dc5) to head (ba2b74b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   86.36%   86.36%   -0.01%     
==========================================
  Files          43       43              
  Lines       11149    11148       -1     
  Branches     2546     2545       -1     
==========================================
- Hits         9629     9628       -1     
  Misses       1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wseymour15 wseymour15 merged commit e4e0c2d into main Sep 11, 2024
14 checks passed
@wseymour15 wseymour15 deleted the fix/audio-timelines-HLS branch September 11, 2024 19:13
wseymour15 added a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants