Skip to content

Commit

Permalink
fix: switch off in-manifest caption support (#8)
Browse files Browse the repository at this point in the history
  • Loading branch information
forbesjo authored Nov 29, 2017
1 parent 973dba0 commit 15712c6
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/toM3u8.js
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ export const toM3u8 = dashPlaylists => {
master.mediaGroups.AUDIO.audio = organizeAudioPlaylists(audioPlaylists);
}

if (vttPlaylists.length) {
// TODO: vtt playlists not yet supported
if (vttPlaylists.length && false) {
master.mediaGroups.SUBTITLES.subs = organizeVttPlaylists(vttPlaylists);
}

Expand Down
4 changes: 4 additions & 0 deletions test/manifests/maat_vtt_segmentTemplate.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ export const parsedManifest = {
}
},
['CLOSED-CAPTIONS']: {},
// Subtitles feature is turned off
SUBTITLES: {},
/*
SUBTITLES: {
subs: {
en: {
Expand Down Expand Up @@ -141,6 +144,7 @@ export const parsedManifest = {
}
}
},
*/
VIDEO: {}
},
playlists: [{
Expand Down
4 changes: 4 additions & 0 deletions test/toM3u8.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ QUnit.test('playlists', function(assert) {
}
},
['CLOSED-CAPTIONS']: {},
// Subtitles feature is turned off
SUBTITLES: {},
/*
SUBTITLES: {
subs: {
text: {
Expand All @@ -110,6 +113,7 @@ QUnit.test('playlists', function(assert) {
}
}
},
*/
VIDEO: {}
},
playlists: [{
Expand Down

0 comments on commit 15712c6

Please sign in to comment.