chore: Update translations script to special case en-GB (#8106)

* chore: Update translations needed script to special case en-GB * update translateions needed
videojs · Feb 21, 2023 · 55cd188 · 55cd188
1 parent a27ee05
commit 55cd188
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/build/translations.js b/build/translations.js
@@ -21,6 +21,15 @@ filepaths.forEach((filepath) => {
   }
 
   const target = require(filepath);
+
+  // Special case for English, the assumption being that since the keys are English only
+  // a  few strings need to be altered for regional differences, e.g. en-GB.
+  if (filename.startsWith('en-')) {
+    console.log(`${filename} English - should be manually checked.`);
+    tableData.push([`${filename} (has ${Object.keys(target).length})`, 'Needs manual checking. Can safely use most default strings.']);
+    return;
+  }
+
   const missing = [];
 
   for (const string in source) {

diff --git a/docs/translations-needed.md b/docs/translations-needed.md
@@ -367,6 +367,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
 |                         | Opacity                                                                             |
 |                         | Text Background                                                                     |
 |                         | Caption Area Background                                                             |
+| en-GB.json (has 1)      | Needs manual checking. Can safely use most default strings. 
 | es.json (Complete)      |                                                                                     |
 | et.json (missing 5)     | No content                                                                          |
 |                         | Color                                                                               |
@@ -775,21 +776,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
 |                         | Opacity                                                                             |
 |                         | Text Background                                                                     |
 |                         | Caption Area Background                                                             |
-| tr.json (missing 18)    | Audio Player                                                                        |
-|                         | Video Player                                                                        |
-|                         | Seek to live, currently behind live                                                 |
-|                         | Seek to live, currently playing live                                                |
-|                         | Progress Bar                                                                        |
-|                         | progress bar timing: currentTime={1} duration={2}                                   |
-|                         | Volume Level                                                                        |
-|                         | Reset                                                                               |
-|                         | restore all settings to the default values                                          |
-|                         | End of dialog window.                                                               |
-|                         | {1} is loading.                                                                     |
-|                         | Exit Picture-in-Picture                                                             |
-|                         | Picture-in-Picture                                                                  |
-|                         | No content                                                                          |
-|                         | Color                                                                               |
+| tr.json (missing 4)     | Color                                                                               |
 |                         | Opacity                                                                             |
 |                         | Text Background                                                                     |
 |                         | Caption Area Background                                                             |

diff --git a/lang/en-GB.json b/lang/en-GB.json
@@ -0,0 +1,4 @@
+{
+  "Color": "Colour"
+}
+