feat: Enable sourceset by default (#7879)

Can still be disabled with enableSourceset: false
videojs · Nov 23, 2022 · b0101a6 · b0101a6
1 parent d4559b1
commit b0101a6
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/src/js/player.js b/src/js/player.js
@@ -5115,6 +5115,9 @@ Player.prototype.options_ = {
 
   html5: {},
 
+  // enable sourceset by default
+  enableSourceset: true,
+
   // default inactivity timeout
   inactivityTimeout: 2000,
 

diff --git a/test/unit/sourceset.test.js b/test/unit/sourceset.test.js
@@ -115,6 +115,49 @@ const setupAfterEach = function(totalSourcesets) {
 const testTypes = ['video el', 'change video el', 'audio el', 'change audio el', 'video-js', 'change video-js el'];
 
 QUnit[qunitFn]('sourceset', function(hooks) {
+  QUnit.module('sourceset option', (subhooks) => testTypes.forEach((testName) => {
+    QUnit.module(testName, {
+      beforeEach() {
+
+        setupEnv(this, testName);
+      },
+      afterEach: setupAfterEach(1)
+    });
+
+    QUnit.test('sourceset enabled by default', function(assert) {
+      const done = assert.async();
+
+      this.mediaEl.setAttribute('data-setup', JSON.stringify({sources: [testSrc]}));
+      this.player = videojs(this.mediaEl, {});
+
+      this.player.one('sourceset', (e) => {
+        validateSource(this.player, [testSrc], e);
+        done();
+      });
+    });
+
+    QUnit.test('sourceset not triggered if turned off', function(assert) {
+      const done = assert.async();
+
+      this.player = videojs(this.mediaEl, {
+        enableSourceset: false
+      });
+
+      this.totalSourcesets = 0;
+
+      this.player.one('sourceset', (e) => {
+        this.totalSourcesets = 1;
+      });
+
+      this.player.on('loadstart', () => {
+        done();
+      });
+
+      this.player.src(testSrc);
+
+    });
+  }));
+
   QUnit.module('source before player', (subhooks) => testTypes.forEach((testName) => {
     QUnit.module(testName, {
       beforeEach() {