Skip to content

Commit

Permalink
fix: update icons import path for sass (#7867)
Browse files Browse the repository at this point in the history
This updates the path to remove node_modules as some tools expect the
module name to be first. This is particularly important for PnP tools as
local node_modules may not have the module.

Fixes #7208, fixes #7863

BREAKING CHANGE: update icons path in sass to remove node_modules
  • Loading branch information
gkatsev authored and misteroneill committed Nov 23, 2022
1 parent 9b3d941 commit bd54b41
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"copy:examples": "shx cp -R docs/examples dist/",
"build:js": "rollup -c",
"build:css": "npm-run-all build:css:*",
"build:css:cdn": "sass --load-path='./' --no-source-map src/css/vjs-cdn.scss dist/alt/video-js-cdn.css",
"build:css:cdn": "sass --load-path='./' --load-path='./node_modules/' --no-source-map src/css/vjs-cdn.scss dist/alt/video-js-cdn.css",
"postbuild:css:cdn": "postcss --verbose --config postcss.config.js -d dist/alt dist/alt/video-js-cdn.css",
"build:css:default": "sass --load-path='./' --no-source-map src/css/vjs.scss dist/video-js.css",
"build:css:default": "sass --load-path='./' --load-path='./node_modules/' --no-source-map src/css/vjs.scss dist/video-js.css",
"postbuild:css:default": "postcss --verbose --config postcss.config.js -d dist/ dist/video-js.css",
"prebuild:lang": "npm-run-all -s prebuild:lang:*",
"prebuild:lang:chinese-s": "shx cp lang/zh-CN.json lang/zh-Hans.json",
Expand Down
2 changes: 1 addition & 1 deletion src/css/video-js.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "private-variables";
@import "utilities";

@import "node_modules/videojs-font/scss/icons";
@import "videojs-font/scss/icons";

@import "components/layout";
@import "components/big-play";
Expand Down

0 comments on commit bd54b41

Please sign in to comment.